Re: [PATCH *-next 01/18] mm/mmu_gather: Remove needless return in void API tlb_remove_page()
From: Peter Zijlstra <peterz@infradead.org>
Date: 2025-02-21 20:02:09
Also in:
linux-arch, linux-crypto, linux-gpio, linux-iommu, linux-mm, linux-pm, linux-rdma, linux-wireless, lkml
On Fri, Feb 21, 2025 at 05:02:06AM -0800, Zijun Hu wrote:
quoted hunk ↗ jump to hunk
Remove needless 'return' in void API tlb_remove_page() since both the API and tlb_remove_page_size() are void functions. Signed-off-by: Zijun Hu <redacted> --- include/asm-generic/tlb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index e402aef79c93..812110813b84 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h@@ -501,7 +501,7 @@ static __always_inline bool __tlb_remove_page(struct mmu_gather *tlb, */ static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) { - return tlb_remove_page_size(tlb, page, PAGE_SIZE); + tlb_remove_page_size(tlb, page, PAGE_SIZE); }
So I don't mind removing it, but note that that return enforces tlb_remove_page_size() has void return type. It might not be your preferred coding style, but it is not completely pointless.