Thread (12 messages) 12 messages, 3 authors, 2025-02-21

Re: [PATCH v2 net-next 2/6] net: hibmcge: Add rx checksum offload supported in this module

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-02-20 23:11:37
Also in: lkml

On Tue, 18 Feb 2025 16:58:25 +0800 Jijie Shao wrote:
quoted hunk ↗ jump to hunk
+static netdev_features_t hbg_net_fix_features(struct net_device *netdev,
+					      netdev_features_t features)
+{
+	return features & HBG_SUPPORT_FEATURES;
+}
Do you need this? Why would the stack try to set features you don't
support/advertize? Also you may clear SW features unnecessarily this
way.
-- 
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help