Thread (5 messages) 5 messages, 3 authors, 2025-02-18

Re: [PATCH] selftests: net: Fix minor typos in MPTCP and psock_tpacket tests

From: Suchit K <hidden>
Date: 2025-02-18 09:28:51
Also in: linux-kernel-mentees, lkml

Hi Jakub. I've reposted the patch. Thanks.

On Tue, 18 Feb 2025 at 05:07, Jakub Kicinski [off-list ref] wrote:
On Mon, 17 Feb 2025 11:08:36 +0100 Matthieu Baerts wrote:
quoted
On 16/02/2025 13:25, Suchit K wrote:
quoted
Fixes minor spelling errors:
- `simult_flows.sh`: "al testcases" → "all testcases"
- `psock_tpacket.c`: "accross" → "across"
The modifications in MPTCP (and psock_tpacket) look good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Thanks! This patch is corrupted:

Applying: selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
error: git diff header lacks filename information when removing 1 leading pathname component (line 7)
Patch failed at 0001 selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Waiting for rebase to finish Mon Feb 17 03:34:36 PM PST 2025^C

So repost will be needed (unless Matt wants to take it into his tree
manually).
quoted
This patch can be applied directly in the netdev tree, but I'm not sure
the Netdev maintainers will accept that kind of small clean-up patch
alone, see:

 https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches
FWIW spelling problems are explicitly called out as okay there.
--
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help