Re: [net-next PATCH v9 3/6] octeontx2-af: CN20k mbox to support AF REQ/ACK functionality
From: Sai Krishna Gajula <hidden>
Date: 2025-02-17 06:31:50
Also in:
lkml, oe-kbuild-all
-----Original Message----- From: kernel test robot <redacted> Sent: Friday, February 14, 2025 8:15 PM To: Sai Krishna Gajula <redacted>; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri Goutham [off-list ref]; Geethasowjanya Akula [off-list ref]; Linu Cherian [off-list ref]; Jerin Jacob [off-list ref]; Hariprasad Kelam [off-list ref]; Subbaraya Sundeep Bhatta [off-list ref]; andrew+netdev@lunn.ch; kalesh- anakkur.purayil@broadcom.com Cc: oe-kbuild-all@lists.linux.dev; Sai Krishna Gajula [off-list ref] Subject: Re: [net-next PATCH v9 3/6] octeontx2-af: CN20k mbox to support AF REQ/ACK functionality Hi Sai, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https: //urldefense. proofpoint. com/v2/url?u=https-3A__github. com_intel- 2Dlab-2Dlkp_linux_commits_Sai-2DKrishna_octeontx2-2DSet-2Dappropriate- 2DPF-2DVF-2Dmasks-2Dand-2Dshifts-2Dbased-2Don-2Dsilicon_20250214- 2D013817&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=c3MsgrR-U- HFhmFd6R4MWRZG- 8QeikJn5PkjqMTpBSg&m=w4DfHXIP7ATUh44fvytYTpSgRUW6g8ZYx6dqfVOVcN U2GPmqe_mFmUKuhQ_axRuJ&s=sO9qAAJJX4lTeQaPpVmgsgnpPvd6IDcoiYl1I kGBsS0&e= Hi Sai, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_intel-2Dlab-2Dlkp_linux_commits_Sai- 2DKrishna_octeontx2-2DSet-2Dappropriate-2DPF-2DVF-2Dmasks-2Dand- 2Dshifts-2Dbased-2Don-2Dsilicon_20250214- 2D013817&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=c3MsgrR-U- HFhmFd6R4MWRZG- 8QeikJn5PkjqMTpBSg&m=w4DfHXIP7ATUh44fvytYTpSgRUW6g8ZYx6dqfVOVcN U2GPmqe_mFmUKuhQ_axRuJ&s=sO9qAAJJX4lTeQaPpVmgsgnpPvd6IDcoiYl1I kGBsS0&e= base: net-next/main patch link: https://urldefense.proofpoint.com/v2/url?u=https- 3A__lore.kernel.org_r_20250213170504.3892412-2D4-2Dsaikrishnag- 2540marvell.com&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=c3MsgrR-U- HFhmFd6R4MWRZG- 8QeikJn5PkjqMTpBSg&m=w4DfHXIP7ATUh44fvytYTpSgRUW6g8ZYx6dqfVOVcN U2GPmqe_mFmUKuhQ_axRuJ&s=qtwhx2D6xBpFQK0j01alE- puPHUuE1Qfmum4l2l7SMY&e= patch subject: [net-next PATCH v9 3/6] octeontx2-af: CN20k mbox to support AF REQ/ACK functionality config: alpha-randconfig-r051-20250214 (https://urldefense.proofpoint.com/v2/url?u=https- 3A__download.01.org_0day- 2Dci_archive_20250214_202502142256.5RFZmK7u-2Dlkp- 40intel.com_config&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=c3MsgrR-U- HFhmFd6R4MWRZG- 8QeikJn5PkjqMTpBSg&m=w4DfHXIP7ATUh44fvytYTpSgRUW6g8ZYx6dqfVOVcN U2GPmqe_mFmUKuhQ_axRuJ&s=le5EhCd0utE4jTExE9dnHS7qBLkWIFk8xRG MbpG0Ilc&e=) compiler: alpha-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://urldefense.proofpoint.com/v2/url?u=https- 3A__download.01.org_0day- 2Dci_archive_20250214_202502142256.5RFZmK7u-2Dlkp- 40intel.com_reproduce&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=c3Msgr R-U-HFhmFd6R4MWRZG- 8QeikJn5PkjqMTpBSg&m=w4DfHXIP7ATUh44fvytYTpSgRUW6g8ZYx6dqfVOVcN U2GPmqe_mFmUKuhQ_axRuJ&s=O7q18F1YKzlDMEVqDjeedVCr9jDiiCFrIgeb7 eIR5ew&e=) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: | https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_o | e-2Dkbuild-2Dall_202502142256.5RFZmK7u-2Dlkp- 40intel.com_&d=DwIBAg&c=n | KjWec2b6R0mOyPaz7xtfQ&r=c3MsgrR-U-HFhmFd6R4MWRZG- 8QeikJn5PkjqMTpBSg&m= | w4DfHXIP7ATUh44fvytYTpSgRUW6g8ZYx6dqfVOVcNU2GPmqe_mFmUKuhQ_a xRuJ&s=4s2 | metuLvTd72yKVjg-_ZuS5HiWwDy_8FGtjJMTIDdY&e= All errors (new ones prefixed by >>): drivers/net/ethernet/marvell/octeontx2/af/rvu.c: In function 'rvu_free_hw_resources':quoted
quoted
drivers/net/ethernet/marvell/octeontx2/af/rvu.c:760:25: error: 'RVU_AFPF' undeclared (first use in this function)760 | pfvf = &rvu->pf[RVU_AFPF]; | ^~~~~~~~
[sai] Ack, will fix and submit V10, though RVU_AFPF is defined in drivers/net/ethernet/marvell/octeontx2/af/rvu.h , it seems to be masked by CONFIG_DEBUG_FS config.
drivers/net/ethernet/marvell/octeontx2/af/rvu.c:760:25: note: each
undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/marvell/octeontx2/af/rvu.c: In function 'rvu_probe':
drivers/net/ethernet/marvell/octeontx2/af/rvu.c:3494:47: error: 'RVU_AFPF'
undeclared (first use in this function)
3494 | rvu_alloc_cint_qint_mem(rvu, &rvu->pf[RVU_AFPF],
BLKADDR_NIX0,
| ^~~~~~~~
vim +/RVU_AFPF +760 drivers/net/ethernet/marvell/octeontx2/af/rvu.c
717
718 static void rvu_free_hw_resources(struct rvu *rvu)
719 {
720 struct rvu_hwinfo *hw = rvu->hw;
721 struct rvu_block *block;
722 struct rvu_pfvf *pfvf;
723 int id, max_msix;
724 u64 cfg;
725
726 rvu_npa_freemem(rvu);
727 rvu_npc_freemem(rvu);
728 rvu_nix_freemem(rvu);
729
730 /* Free block LF bitmaps */
731 for (id = 0; id < BLK_COUNT; id++) {
732 block = &hw->block[id];
733 kfree(block->lf.bmap);
734 }
735
736 /* Free MSIX bitmaps */
737 for (id = 0; id < hw->total_pfs; id++) {
738 pfvf = &rvu->pf[id];
739 kfree(pfvf->msix.bmap);
740 }
741
742 for (id = 0; id < hw->total_vfs; id++) {
743 pfvf = &rvu->hwvf[id];
744 kfree(pfvf->msix.bmap);
745 }
746
747 /* Unmap MSIX vector base IOVA mapping */
748 if (!rvu->msix_base_iova)
749 return;
750 cfg = rvu_read64(rvu, BLKADDR_RVUM, RVU_PRIV_CONST);
751 max_msix = cfg & 0xFFFFF;
752 dma_unmap_resource(rvu->dev, rvu->msix_base_iova,
753 max_msix * PCI_MSIX_ENTRY_SIZE,
754 DMA_BIDIRECTIONAL, 0);
755
756 rvu_reset_msix(rvu);
757 mutex_destroy(&rvu->rsrc_lock);
758
759 /* Free the QINT/CINt memory */
> 760 pfvf = &rvu->pf[RVU_AFPF];
761 qmem_free(rvu->dev, pfvf->nix_qints_ctx);
762 qmem_free(rvu->dev, pfvf->cq_ints_ctx);
763 }