Thread (3 messages) 3 messages, 3 authors, 2025-02-15

Re: [PATCH v2 net-next] ice: Fix signedness bug in ice_init_interrupt_scheme()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-02-15 03:50:01
Also in: intel-wired-lan, kernel-janitors, lkml

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Thu, 13 Feb 2025 09:31:41 +0300 you wrote:
If pci_alloc_irq_vectors() can't allocate the minimum number of vectors
then it returns -ENOSPC so there is no need to check for that in the
caller.  In fact, because pf->msix.min is an unsigned int, it means that
any negative error codes are type promoted to high positive values and
treated as success.  So here, the "return -ENOMEM;" is unreachable code.
Check for negatives instead.

[...]
Here is the summary with links:
  - [v2,net-next] ice: Fix signedness bug in ice_init_interrupt_scheme()
    https://git.kernel.org/netdev/net-next/c/c2ddb619fa8d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help