On Wed, Feb 12, 2025 at 05:59:01PM -0800, Jakub Kicinski wrote:

On Wed, 12 Feb 2025 17:46:54 +0100 Alexander Lobakin wrote:

quoted

quoted

[PATCH next] ice: Fix signedness bug in ice_init_interrupt_scheme()  

I believe it should be "PATCH net" with

quoted

If pci_alloc_irq_vectors() can't allocate the minimum number of vectors
then it returns -ENOSPC so there is no need to check for that in the
caller.  In fact, because pf->msix.min is an unsigned int, it means that
any negative error codes are type promoted to high positive values and
treated as success.  So here the "return -ENOMEM;" is unreachable code.
Check for negatives instead.

Fixes: 79d97b8cf9a8 ("ice: remove splitting MSI-X between features")  

a 'Stable:' tag here.

Bug only exists in net-next if it comes from commit under Fixes.
So I think the patch is good as is.

I want to resen this.  My scripts should have put a net-next in the
subject and I think that changing:

-		return -ENOMEM;
+		return vectors;

actually does fall within the scope of the patch so I want to change
that as well.  There is no point in really breaking that into a separate
patch from a practical perspective.

regards,
dan carpenter