Re: [PATCH] blackhole_dev: convert self-test to KUnit

From
Tamir Duberstein <hidden>
Date
2025-02-11 15:33:10
Also in
linux-kselftest, lkml, llvm
Reply to
Simon Horman, 2025-02-11
On Tue, Feb 11, 2025 at 9:47 AM Simon Horman [off-list ref] wrote:
On Fri, Feb 07, 2025 at 06:38:41PM -0500, Tamir Duberstein wrote:
quoted
Convert this very simple smoke test to a KUnit test.
Hi Tamir,

I think some text explaining why this change is being made is
warranted here.
Hi Simon, I think that would be stating KUnit's raison d'etre? I
followed Kees' lead as seen in
https://lore.kernel.org/all/20240612195921.2685842-2-kees@kernel.org/ (local).

In this case we saw the benefit right away: kernel test robot
immediately spotted and reported a bug which I fixed in v2:
https://lore.kernel.org/all/20250208-blackholedev-kunit-convert-v2-1-182db9bd56ec@gmail.com/ (local).
Weirdly this message is absent from lore, but should be in your inbox
(and my reply to it *is* present on lore).
quoted
Signed-off-by: Tamir Duberstein <redacted>
---
I tested this using:

$ tools/testing/kunit/kunit.py run --arch arm64 --make_options LLVM=1 --kconfig_add CONFIG_NET=y blackholedev
...
Thread (5 messages) 5 messages, 3 authors, last reply 2025-02-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help