Thread (33 messages) 33 messages, 7 authors, 2025-02-08

Re: [PATCH v2 04/13] bus: ts-nbus: use gpiod_multi_set_value_cansleep

From: Andy Shevchenko <hidden>
Date: 2025-02-07 12:18:27
Also in: linux-gpio, linux-iio, linux-mmc, linux-phy, linux-sound, lkml

+Yury.

On Fri, Feb 7, 2025 at 2:15 PM Andy Shevchenko
[off-list ref] wrote:
On Fri, Feb 7, 2025 at 12:48 AM David Lechner [off-list ref] wrote:
...
quoted
 static void ts_nbus_write_byte(struct ts_nbus *ts_nbus, u8 byte)
 {
-       struct gpio_descs *gpios = ts_nbus->data;
        DECLARE_BITMAP(values, 8);

        values[0] = byte;

-       gpiod_set_array_value_cansleep(8, gpios->desc, gpios->info, values);
+       gpiod_multi_set_value_cansleep(ts_nbus->data, values);
As I said before, this is buggy code on BE64. Needs to be fixed.
Or isn't? Do we have a test case in bitmap for such a case?
quoted
 }

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help