Re: [PATCH v2 1/2] net, treewide: define and use MAC_ADDR_LEN

From
Johannes Berg <johannes@sipsolutions.net>
Date
2025-02-05 07:26:24
Also in
linux-doc, linux-wireless, lkml
Reply to
Uday Shankar, 2025-02-04
On Tue, 2025-02-04 at 14:41 -0700, Uday Shankar wrote:
There are a few places in the tree which compute the length of the
string representation of a MAC address as 3 * ETH_ALEN - 1. Define a
constant for this and use it where relevant. No functionality changes
are expected.
True ... but is "MAC_ADDR_LEN" really an appropriate name for that? Just
plain reading the subject, my first thought was why you weren't going to
use ETH_ALEN.

Would seem nicer to me, at least, to have something indicating a
*string* in there, e.g. MAC_ADDR_STR_LEN or so.

johannes
Thread (7 messages) 7 messages, 4 authors, last reply 2025-02-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help