Re: [PATCH v1 0/9] Use HWMON_CHANNEL_INFO macro to simplify code
From: "lihuisong (C)" <lihuisong@huawei.com>
Date: 2025-02-05 02:23:53
Also in:
linux-hwmon, linux-media, linux-rtc, lkml
在 2025/1/24 23:41, Guenter Roeck 写道:
On 1/24/25 07:08, Andrew Lunn wrote:quoted
On Fri, Jan 24, 2025 at 10:26:26AM +0800, Huisong Li wrote:quoted
The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code. Huisong Li (9): media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code net: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code net: nfp: Use HWMON_CHANNEL_INFO macro to simplify code net: phy: marvell: Use HWMON_CHANNEL_INFO macro to simplify code net: phy: marvell10g: Use HWMON_CHANNEL_INFO macro to simplify code rtc: ab-eoz9: Use HWMON_CHANNEL_INFO macro to simplify code rtc: ds3232: Use HWMON_CHANNEL_INFO macro to simplify code w1: w1_therm: w1: Use HWMON_CHANNEL_INFO macro to simplify code net: phy: aquantia: Use HWMON_CHANNEL_INFO macro to simplify codePlease split these patches per subsystem. Maintainers generally have scripts to accept patches, and those scripts don't work when there are patches for other Maintainers mixed in. So you need 4 patchsets, media, net, rtc and w1. I would also like to see the HWMON Maintainers opinion on these. A patchset containing these have already been NACKed once. These patches do however look like valid cleanups. But are they just so you can do something bad in your vendor tree, which will never make it to mainline?I no longer comment on hwmon related changes outside drivers/hwmon/ unless there are blatant problems such as someone trying to use an obsolete API or abusing the current API.
All right. Let subsystem maintainer to decide if need to pick it up.
.