Thread (9 messages) 9 messages, 3 authors, 2025-02-27

Re: [PATCH net-next 1/4] sock: add sock_kmemdup helper

From: Geliang Tang <geliang@kernel.org>
Date: 2025-02-27 09:09:01
Also in: linux-sctp, mptcp

On Thu, 2025-02-27 at 09:45 +0100, Matthieu Baerts wrote:
Hi Geliang,

On 27/02/2025 09:23, Geliang Tang wrote:
quoted
From: Geliang Tang <redacted>

This patch adds the sock version of kmemdup() helper, named
sock_kmemdup(),
to duplicate the input "src" memory block using the socket's option
memory
buffer.
Thank you for suggesting this series.

(...)
quoted
diff --git a/net/core/sock.c b/net/core/sock.c
index 5ac445f8244b..95e81d24f4cc 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -2819,6 +2819,21 @@ void *sock_kmalloc(struct sock *sk, int
size, gfp_t priority)
 }
 EXPORT_SYMBOL(sock_kmalloc);
 
+/*
+ * Duplicate the input "src" memory block using the socket's
+ * option memory buffer.
+ */
+void *sock_kmemdup(struct sock *sk, const void *src,
+		   int size, gfp_t priority)
+{
+	void *mem;
+
+	mem = sock_kmalloc(sk, size, priority);
+	if (mem)
+		memcpy(mem, src, size);
+	return mem;
+}

I think you will need to add an EXPORT_SYMBOL() here, if you plan to
use
it in SCTP which can be compiled as a module.
Yes, indeed. I'll add this in v2.

Thanks,
-Geliang
Cheers,
Matt
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help