Re: [PATCH net-next v2 2/7] net: initialize mark in sockcm_init
From: Paolo Abeni <pabeni@redhat.com>
Date: 2025-02-13 18:12:47
From: Paolo Abeni <pabeni@redhat.com>
Date: 2025-02-13 18:12:47
On 2/13/25 4:35 PM, Willem de Bruijn wrote:
Paolo Abeni wrote:quoted
On 2/12/25 3:09 AM, Willem de Bruijn wrote:quoted
From: Willem de Bruijn <willemb@google.com> Avoid open coding initialization of sockcm fields. Avoid reading the sk_priority field twice. This ensures all callers, existing and future, will correctly try a cmsg passed mark before sk_mark. This patch extends support for cmsg mark to: packet_spkt and packet_tpacket and net/can/raw.c. This patch extends support for cmsg priority to: packet_spkt and packet_tpacket.I admit I'm a little bit concerned vs possibly impacting existing applications doing weird thing like passing the relevant cmsg and expecting it to be ignored.We have a history of expanding support for passing variables by cmsg.
Ok, I should have paid more attention to other cmsg related changes. git log says this is actually allowed, so I'm fine with the patch. Thanks, Paolo