Re: [PATCH net 6/8] vrf: use RCU protection in l3mdev_l3_out()

From
Kuniyuki Iwashima <hidden>
Date
2025-02-10 01:27:53
Reply to
Eric Dumazet, 2025-02-07
From: Eric Dumazet <redacted>
Date: Fri,  7 Feb 2025 13:58:38 +0000
l3mdev_l3_out() can be called without RCU being held:

raw_sendmsg()
 ip_push_pending_frames()
  ip_send_skb()
   ip_local_out()
    __ip_local_out()
     l3mdev_ip_out()

Add rcu_read_lock() / rcu_read_unlock() pair to avoid
a potential UAF.

Fixes: a8e3e1a9f020 ("net: l3mdev: Add hook to output path")
Signed-off-by: Eric Dumazet <redacted>
Reviewed-by: Kuniyuki Iwashima <redacted>

I wondered why syzbot didn't notice this and I confirmed that
list_first_or_null_rcu() doesn't have RCU annotation.
Thread (25 messages) 25 messages, 4 authors, last reply 2025-02-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help