Thread (3 messages) 3 messages, 2 authors, 2025-01-20

Re: [PATCH v15 1/1] mctp pcc: Implement MCTP over PCC Transport

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-01-20 22:43:29
Also in: lkml

On Wed, 15 Jan 2025 14:52:17 -0500 admiyo@os.amperecomputing.com wrote:
+	rc = devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);
+	if (rc)
+		goto cleanup_netdev;
devm_add_action_or_reset() calls the cleanup handler on failure,
so just

	return devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);

directly. As is you'll double free the netdev on failure.
+	return rc;
+cleanup_netdev:
+	free_netdev(ndev);
-- 
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help