Thread (4 messages) 4 messages, 4 authors, 2025-01-18

Re: [PATCH][next] net/mlx5: fix unintentional sign extension on shift of dest_attr->vport.vhca_id

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-01-18 04:00:11
Also in: kernel-janitors, linux-rdma, lkml

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Thu, 16 Jan 2025 18:17:00 +0000 you wrote:
Shifting dest_attr->vport.vhca_id << 16 results in a promotion from an
unsigned 16 bit integer to a 32 bit signed integer, this is then sign
extended to a 64 bit unsigned long on 64 bitarchitectures. If vhca_id is
greater than 0x7fff then this leads to a sign extended result where all
the upper 32 bits of idx are set to 1. Fix this by casting vhca_id
to the same type as idx before performing the shift.

[...]
Here is the summary with links:
  - [next] net/mlx5: fix unintentional sign extension on shift of dest_attr->vport.vhca_id
    https://git.kernel.org/netdev/net-next/c/41c5d104f338

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help