Thread (13 messages) 13 messages, 5 authors, 2025-01-13

Re: [PATCH net-next 0/3] virtio_net: Link queues to NAPIs

From: Lei Yang <hidden>
Date: 2025-01-13 06:03:50
Also in: lkml, virtualization

I tested this series of patches with virtio-net regression tests,
everything works fine.

Tested-by: Lei Yang <redacted>


On Sat, Jan 11, 2025 at 4:26 AM Joe Damato [off-list ref] wrote:
Greetings:

Recently [1], Jakub mentioned that there were a few drivers that are not
yet mapping queues to NAPIs.

While I don't have any of the other hardware mentioned, I do happen to
have a virtio_net laying around ;)

I've attempted to link queues to NAPIs, taking care to hold RTNL when it
seemed that the path was not already holding it.

Note: It seems virtio_net uses TX-only NAPIs which do not have NAPI IDs.
As such, I've left the TX NAPIs unset (as opposed to setting them to 0).

See the commit message of patch 3 for example out to see what I mean.

Thanks,
Joe

[1]: https://lore.kernel.org/netdev/20250109084301.2445a3e3@kernel.org/ (local)

Joe Damato (3):
  virtio_net: Prepare for NAPI to queue mapping
  virtio_net: Hold RTNL for NAPI to queue mapping
  virtio_net: Map NAPIs to queues

 drivers/net/virtio_net.c | 48 ++++++++++++++++++++++++++++++++++++----
 1 file changed, 44 insertions(+), 4 deletions(-)


base-commit: 7b24f164cf005b9649138ef6de94aaac49c9f3d1
--
2.25.1
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help