Re: [PATCH] rhashtable: Fix potential deadlock by moving schedule_work outside lock
From: Breno Leitao <leitao@debian.org>
Date: 2025-01-09 10:15:22
Also in:
linux-hyperv, lkml
From: Breno Leitao <leitao@debian.org>
Date: 2025-01-09 10:15:22
Also in:
linux-hyperv, lkml
Hello Michael, On Thu, Jan 09, 2025 at 03:16:03AM +0000, Michael Kelley wrote:
From: Breno Leitao <leitao@debian.org> Sent: Thursday, January 2, 2025 2:16 AMquoted
On Sat, Dec 21, 2024 at 05:06:55PM +0800, Herbert Xu wrote:quoted
On Thu, Dec 12, 2024 at 08:33:31PM +0800, Herbert Xu wrote:quoted
The growth check should stay with the atomic_inc. Something like this should work:OK I've applied your patch with the atomic_inc move.Sorry, I was on vacation, and I am back now. Let me know if you need anything further. Thanks for fixing it, --brenoBreno and Herbert -- This patch seems to break things in linux-next. I'm testing with linux-next20250108 in a VM in the Azure public cloud. The Mellanox mlx5 ethernet NIC in the VM is failing to get setup.
Thanks for reporting the issue. I started rolling this patch to Meta's fleet, and we started seeing a similar problem. Altough not fully understood yet. I would suggest we revert this patch until we investigate further. I'll prepare and send a revert patch shortly. Sorry for the noise, --breno