Thread (4 messages) 4 messages, 4 authors, 2025-01-09

Re: [PATCH net] rtase: Fix a check for error in rtase_alloc_msix()

From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Date: 2025-01-08 12:17:01
Also in: kernel-janitors, lkml

On Wed, Jan 8, 2025 at 2:46 PM Dan Carpenter [off-list ref] wrote:
The pci_irq_vector() function never returns zero.  It returns negative
error codes or a positive non-zero IRQ number.  Fix the error checking to
test for negatives.

Fixes: a36e9f5cfe9e ("rtase: Add support for a pci table in this module")
Signed-off-by: Dan Carpenter <redacted>
LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>


-- 
Regards,
Kalesh AP

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help