Re: [PATCH] hamradio: baycom: replace strcpy() with strscpy()
From: Dan Carpenter <hidden>
Date: 2025-01-06 09:55:13
Also in:
linux-hams, lkml
On Mon, Dec 23, 2024 at 03:13:42PM +0000, Ethan Carter Edwards wrote:
quoted hunk ↗ jump to hunk
The strcpy() function has been deprecated and replaced with strscpy(). There is an effort to make this change treewide: https://github.com/KSPP/linux/issues/88. Signed-off-by: Ethan Carter Edwards <redacted> --- drivers/net/hamradio/baycom_par.c | 4 ++-- drivers/net/hamradio/baycom_ser_fdx.c | 2 +- drivers/net/hamradio/baycom_ser_hdx.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)diff --git a/drivers/net/hamradio/baycom_par.c b/drivers/net/hamradio/baycom_par.c index 00ebc25d0b22..47bc74d3ad8c 100644 --- a/drivers/net/hamradio/baycom_par.c +++ b/drivers/net/hamradio/baycom_par.c@@ -427,7 +427,7 @@ static int baycom_ioctl(struct net_device *dev, void __user *data, break; case HDLCDRVCTL_GETMODE: - strcpy(hi->data.modename, bc->options ? "par96" : "picpar"); + strscpy(hi->data.modename, bc->options ? "par96" : "picpar", sizeof(hi->data.modename));
strscpy() has macro magic so you can just write this as: strscpy(hi->data.modename, bc->options ? "par96" : "picpar"); Looks nicer and it's easier to review. regards, dan carpenter