Re: [PATCH v11 0/1] MCTP Over PCC Transport
From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2025-01-06 01:05:58
Also in:
lkml
From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2025-01-06 01:05:58
Also in:
lkml
Hi Adam,
Changes in V11: - Switch Big Endian data types to machine local for PCC header
This seems suspicious; the concept of "machine local" may not be consistent between channel endpoints (ie, system firmware and this driver). Looking at DSP0292, and the PCC channel spec, it looks like these should be explicitly little-endian, no? The warnings you were seeing in v10 seemed to be an issue of direct accesses to the __be32 types in struct mctp_pcc_hdr - ie., without be32_to_cpu() accessors. If you keep the endian-annotated types (but __le32 instead), and use the appropriate le32_to_cpu() accessors, that should address those warnings, while keeping the driver endian-safe. Cheers, Jeremy