Re: [PATCH 1/2] net: wwan: iosm: Properly check for valid exec stage in ipc_mmio_init()
From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-01-03 02:50:19
Also in:
lkml
From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-01-03 02:50:19
Also in:
lkml
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski [off-list ref]: On Sun, 29 Dec 2024 17:46:58 +0100 you wrote:
ipc_mmio_init() used the post-decrement operator in its loop continuing condition of "retries" counter being "> 0", which meant that when this condition caused loop exit "retries" counter reached -1. But the later valid exec stage failure check only tests for "retries" counter being exactly zero, so it didn't trigger in this case (but would wrongly trigger if the code reaches a valid exec stage in the very last loop iteration). [...]
Here is the summary with links:
- [1/2] net: wwan: iosm: Properly check for valid exec stage in ipc_mmio_init()
https://git.kernel.org/netdev/net/c/a7af435df0e0
- [2/2] net: wwan: iosm: Fix hibernation by re-binding the driver around it
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html