On 02/01/2025 at 14:40, Ming Yu wrote:

Dear Vincent,

Thank you for your comments,

Vincent Mailhol [off-list ref] 於 2024年12月30日 週一 下午1:56寫道：

quoted

quoted

+config CAN_NCT6694
+     tristate "Nuvoton NCT6694 Socket CANfd support"
+     depends on MFD_NCT6694

I think it would be better to do a

        select MFD_NCT6694

here.

Then, make MFD_NCT6694 an hidden configuration in a similar fashion as
MFD_CORE. Alone, CONFIG_MFD_NCT6694 does nothing, so better to hide it
from the end user.

The comment also applies to the other patches.

I understand, but I noticed that in the Kconfig files of other
modules, the dependency is written in the form:
config CAN_NCT6694
        tristate "Nuvoton NCT6694 Socket CANfd support"
        depends on MFD_NCT6694
(e.g. CAN_JANZ_ICAN3, GPIO_DLN2, ...)
Do you think changing it to select MFD_NCT6694 would be better?

That's a fair point. Looking at the examples you provided, your approach
makes sense. Please ignore my comment here.


Yours sincerely,
Vincent Mailhol