Re: [PATCH net v2 1/7] eth: tg3: fix calling napi_enable() in atomic context

On Wed, Jan 22, 2025 at 4:45 PM Jakub Kicinski [off-list ref] wrote:

tg3 has a spin lock protecting most of the config,
switch to taking netdev_lock() explicitly on enable/start
paths. Disable/stop paths seem to not be under the spin
lock (since napi_disable() already needs to sleep),
so leave that side as is.

tg3_restart_hw() releases and re-takes the spin lock,
we need to do the same because dev_close() needs to
take netdev_lock().

Fixes: 413f0271f396 ("net: protect NAPI enablement with netdev_lock()")
Reported-by: Dan Carpenter <redacted>
Link: https://lore.kernel.org/dcfd56bc-de32-4b11-9e19-d8bd1543745d@stanley.mountain (local)
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

The relocking annotation seems to be in the wrong function.  It should
be in tg3_restart_hw().  Other than that,

Reviewed-by: Michael Chan <michael.chan@broadcom.com>