Re: [PATCH net-next V5 07/11] devlink: Extend devlink rate API with traffic classes bandwidth management

On 21/01/2025 14:36, Carolina Jubran wrote:

On 20/01/2025 20:14, Jakub Kicinski wrote:

quoted

On Mon, 20 Jan 2025 13:55:58 +0200 Carolina Jubran wrote:

quoted

On 09/12/2024 23:27, Jakub Kicinski wrote:

quoted

On Mon, 9 Dec 2024 23:03:04 +0200 Tariq Toukan wrote:

quoted

If we enforce by policy we need to use the constant 7, not the macro
IEEE_8021QAZ_MAX_TCS-1.
I'll keep it.

The spec should support using "foreign constants"
Off the top of my head - you can define the ieee-8021qaz-max-tcs contant
as if you were defining a devlink constant, then add a header:
attribute. This will tell C codegen to include that header instead of
generating the definition.

Hi Jakub,

I tried implementing this as you suggested, but it seems that the only
supported definition types are ['const', 'enum', 'flags', 'struct'],
while the max value in checks only accepts patterns matching
^[su](8|16|32|64)-(min|max)$.

  From what I see, it doesn’t currently support using a const value for
the max or min checks. Let me know if I’m missing something or if
there’s an alternative way to achieve this.

Ah, I thought we already implemented this, sorry.
Can you try the two patches from the top of this branch?

https://github.com/kuba-moo/linux/tree/ynl-limits

Yes, it worked after applying the pattern changes to the
genetlink-legacy.yaml , as devlink uses it.

Thank you!

Carolina

Since this worked and the devlink patch now depends on it, would it be possible to include the top two patches
https://github.com/kuba-moo/linux/tree/ynl-limits in the next submission of the devlink and mlx5 patches?

Thanks!
Carolina