Thread (26 messages) 26 messages, 3 authors, 2025-02-13

Re: [PATCH v3 01/14] net-next/yunsilicon: Add xsc driver basic framework

flat view

From: Simon Horman <horms@kernel.org>
Date: 2025-01-15 16:04:16

On Wed, Jan 15, 2025 at 06:22:44PM +0800, Xin Tian wrote:
Add yunsilicon xsc driver basic framework, including xsc_pci driver
and xsc_eth driver

Co-developed-by: Honggang Wei <redacted>
Signed-off-by: Honggang Wei <redacted>
Co-developed-by: Lei Yan <redacted>
Signed-off-by: Lei Yan <redacted>
Signed-off-by: Xin Tian <redacted>
...
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/yunsilicon/xsc/pci/Makefile b/drivers/net/ethernet/yunsilicon/xsc/pci/Makefile
new file mode 100644
index 000000000..709270df8
--- /dev/null
+++ b/drivers/net/ethernet/yunsilicon/xsc/pci/Makefile
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2021-2025, Shanghai Yunsilicon Technology Co., Ltd.
+# All rights reserved.
+
+ccflags-y += -I$(srctree)/drivers/net/ethernet/yunsilicon/xsc
+
+obj-$(CONFIG_YUNSILICON_XSC_PCI) += xsc_pci.o
+
+xsc_pci-y := main.o
diff --git a/drivers/net/ethernet/yunsilicon/xsc/pci/main.c b/drivers/net/ethernet/yunsilicon/xsc/pci/main.c
new file mode 100644
index 000000000..4859be58f
--- /dev/null
+++ b/drivers/net/ethernet/yunsilicon/xsc/pci/main.c
@@ -0,0 +1,251 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (C) 2021-2025, Shanghai Yunsilicon Technology Co., Ltd.
+ * All rights reserved.
+ */
+
+#include "common/xsc_core.h"
Hi Xin Tian, all,

Sorry for not noticing this before sending my previous email.

Please consider a relative include like the following,
rather than the above combined with a -I directive in the Makefile.

#include "../common/xsc_core.h"

This is common practice in Networking code.
And, for one thing, allows the following to work:

make drivers/net/ethernet/yunsilicon/xsc/pci/main.o

...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help