Thread (34 messages) flat view 34 messages, 4 authors, 2025-01-14

Re: [PATCH net-next 06/11] net: protect NAPI enablement with netdev_lock()

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2025-01-14 23:01:26

Jakub Kicinski [off-list ref] :
Wrap napi_enable() / napi_disable() with netdev_lock().
Provide the "already locked" flavor of the API"

iavf needs the usual adjustment. A number of drivers call
napi_enable() under a spin lock, so they have to be modified
to take netdev_lock() first, then spin lock then call
napi_enable_locked().

Protecting napi_enable() implies that napi->napi_id is protected
by netdev_lock().

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
[...]
---
 include/linux/netdevice.h                   | 11 ++----
 drivers/net/ethernet/amd/pcnet32.c          | 11 +++++-
 drivers/net/ethernet/intel/iavf/iavf_main.c |  4 +-
 drivers/net/ethernet/marvell/mvneta.c       |  5 ++-
 drivers/net/ethernet/via/via-velocity.c     |  4 +-
For the via-velocity part:

Acked-by: Francois Romieu <romieu@fr.zoreil.com>

-- 
Ueimor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help