-----Original Message-----
From: Daniel Zahka <daniel.zahka@gmail.com>
Sent: Tuesday, 7 January 2025 15:18
To: Danielle Ratson <redacted>
Cc: netdev@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; Ido Schimmel
[off-list ref]; mkubecek@suse.cz
Subject: Re: [RFC ethtool] ethtool: mock JSON output for --module-info

The json output looks good on my cards with CMIS modules. On a different
card that does not support the CMIS interface, the output falls back to non-
json, even when --json is specified. Maybe this should return an error. Other
than that, looks good to me. Thanks.

This code adds support only for CMIS modules, I am working on combining all the modules json support together and doing a refactoring work that was needed.

Did you take a look at the code? Any comments there?

Thanks,
Danielle

On 1/2/25 3:19 AM, Danielle Ratson wrote:

quoted

Hi,

Any comments?

quoted

-----Original Message-----
From: Daniel Zahka <daniel.zahka@gmail.com>
Sent: Thursday, 19 December 2024 19:35
To: Danielle Ratson <redacted>
Cc: netdev@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; Ido
Schimmel [off-list ref]; mkubecek@suse.cz
Subject: Re: [RFC ethtool] ethtool: mock JSON output for
--module-info


On 12/19/24 9:18 AM, Danielle Ratson wrote:

quoted

Hi Daniel,

I didn’t get a reply from you.
Anyway, here's a like to my git repository:

https://github.com/daniellerts/ethtool/tree/eeprom_json_rfc.

quoted

The last 4 commits are the relevant ones.

All the CMIS modules dump fields are implemented were sent to
internal

review.

quoted

Thanks,
Danielle

Thank you! I'll try it out on my machines.