Thread (6 messages) 6 messages, 3 authors, 2025-01-06

Re: [PATCH net-next] team: prevent adding a device which is already a team device lower

From: patchwork-bot+netdevbpf@kernel.org
Date: 2025-01-03 12:00:16

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller [off-list ref]:

On Mon, 30 Dec 2024 12:56:47 -0800 you wrote:
Prevent adding a device which is already a team device lower,
e.g. adding veth0 if vlan1 was already added and veth0 is a lower of
vlan1.

This is not useful in practice and can lead to recursive locking:

$ ip link add veth0 type veth peer name veth1
$ ip link set veth0 up
$ ip link set veth1 up
$ ip link add link veth0 name veth0.1 type vlan protocol 802.1Q id 1
$ ip link add team0 type team
$ ip link set veth0.1 down
$ ip link set veth0.1 master team0
team0: Port device veth0.1 added
$ ip link set veth0 down
$ ip link set veth0 master team0

[...]
Here is the summary with links:
  - [net-next] team: prevent adding a device which is already a team device lower
    https://git.kernel.org/netdev/net-next/c/3fff5da4ca21

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help