Thread (2 messages) 2 messages, 2 authors, 2024-12-27

Re: [PATCH] eth: fbnic: Avoid garbage value in fbnic_mac_get_sensor_asic()

From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-12-27 18:56:32
Also in: kernel-janitors, lkml

On Tue, 24 Dec 2024 10:27:29 +0800 Su Hui wrote:
'fw_cmpl' is uninitialized which makes 'sensor' and '*val' to be stored
garbage value. Initialize 'fw_cmpl' with 'fdb->cmpl_data' to fix this
problem.
Argh, this function should send a FW command to read the sensors, 
it does nothing today :/ Looks like an upstreaming fail..

If you'd like to fix this please just remove the body of the function
entirely and return -EOPNOTSUPP. We'll have to follow up in net-next
to fill in the gaps in sensor reading.
-- 
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help