Re: [PATCH net] xfrm: prevent some integer overflows in verify_ functions

[PATCH net] xfrm: prevent some integer overflows in verify_ functions · Dan Carpenter <hidden> · 2024-12-17
Re: [PATCH net] xfrm: prevent some integer overflows in verify_ functions · Herbert Xu <herbert@gondor.apana.org.au> · 2024-12-17
Re: [PATCH net] xfrm: prevent some integer overflows in verify_ functions · Dan Carpenter <hidden> · 2024-12-17
[PATCH net] xfrm: Rewrite key length conversion to avoid overflows · Herbert Xu <herbert@gondor.apana.org.au> · 2024-12-18
Re: [PATCH net] xfrm: Rewrite key length conversion to avoid overflows · Dan Carpenter <hidden> · 2024-12-18
Re: [PATCH net] xfrm: Rewrite key length conversion to avoid overflows · Herbert Xu <herbert@gondor.apana.org.au> · 2024-12-18

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2024-12-17 12:04:09
Also in: kernel-janitors, lkml

On Tue, Dec 17, 2024 at 11:42:31AM +0300, Dan Carpenter wrote:

+	if (algp->alg_key_len > INT_MAX) {

Why not check for UINT_MAX - 7? INT_MAX seems a bit arbitrary.

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help