Thread (3 messages) 3 messages, 3 authors, 2024-12-17

Re: [PATCH net] net: hinic: Fix cleanup in create_rxqs/txqs()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2024-12-17 02:30:13
Also in: kernel-janitors, lkml

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Fri, 13 Dec 2024 17:28:11 +0300 you wrote:
There is a check for NULL at the start of create_txqs() and
create_rxqs() which tess if "nic_dev->txqs" is non-NULL.  The
intention is that if the device is already open and the queues
are already created then we don't create them a second time.

However, the bug is that if we have an error in the create_txqs()
then the pointer doesn't get set back to NULL.  The NULL check
at the start of the function will say that it's already open when
it's not and the device can't be used.

[...]
Here is the summary with links:
  - [net] net: hinic: Fix cleanup in create_rxqs/txqs()
    https://git.kernel.org/netdev/net/c/7203d10e93b6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help