I tested this series v4 patches with virtio-net regression tests, all
cases test pass. But I hit a bug
https://bugzilla.kernel.org/show_bug.cgi?id=219588, only judging from
call trace info it should be a CPU issue, and not related to the
current patch.

Tested-by: Lei Yang <redacted>

On Tue, Dec 10, 2024 at 6:40 PM [off-list ref] wrote:

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni [off-list ref]:

On Fri,  6 Dec 2024 10:10:41 +0900 you wrote:

quoted

When virtnet_close is followed by virtnet_open, some TX completions can
possibly remain unconsumed, until they are finally processed during the
first NAPI poll after the netdev_tx_reset_queue(), resulting in a crash
[1]. Commit b96ed2c97c79 ("virtio_net: move netdev_tx_reset_queue() call
before RX napi enable") was not sufficient to eliminate all BQL crash
scenarios for virtio-net.

[...]

Here is the summary with links:
  - [net,v4,1/6] virtio_net: correct netdev_tx_reset_queue() invocation point
    https://git.kernel.org/netdev/net/c/3ddccbefebdb
  - [net,v4,2/6] virtio_net: replace vq2rxq with vq2txq where appropriate
    https://git.kernel.org/netdev/net/c/4571dc7272b2
  - [net,v4,3/6] virtio_ring: add a func argument 'recycle_done' to virtqueue_resize()
    https://git.kernel.org/netdev/net/c/8d6712c89201
  - [net,v4,4/6] virtio_net: ensure netdev_tx_reset_queue is called on tx ring resize
    https://git.kernel.org/netdev/net/c/1480f0f61b67
  - [net,v4,5/6] virtio_ring: add a func argument 'recycle_done' to virtqueue_reset()
    https://git.kernel.org/netdev/net/c/8d2da07c813a
  - [net,v4,6/6] virtio_net: ensure netdev_tx_reset_queue is called on bind xsk for tx
    https://git.kernel.org/netdev/net/c/76a771ec4c9a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html