Thread (2 messages) 2 messages, 2 authors, 2024-12-09

Re: linux-next: Fixes tag needs some work in the bpf-next tree

From: Alexei Starovoitov <hidden>
Date: 2024-12-09 17:19:03
Also in: bpf, linux-next, lkml

On Sun, Dec 8, 2024 at 11:16 PM Stephen Rothwell [off-list ref] wrote:
Hi all,

In commit

  c721d8f8b196 ("selftests/bpf: ensure proper root namespace cleanup when test fail")

Fixes tag

  Fixes: 284ed00a59dd ("selftests/bpf: migrate flow_dissector namespace exclusivity test")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 6fb5be12d1bb ("selftests/bpf: migrate flow_dissector namespace exclusivity test")
I believe the fixes tag was correct when it was first applied
during merge window (without being in for-next),
but then bpf-next/master was rebased after rc1 was released
and fixes tag became wrong.
Now the commit c721d8f8b196 is so far down that we cannot fix it and
force push it. We don't rebase after rc1 either.
Sadly it would have to stay this way.
We probably need to run our pw-check [0] script during the rebase
to make sure such mistakes don't happen.

[0]
https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/pw.git/tree/pw-check
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help