Re: [PATCH net-next v8 10/15] net: macb: Use helper rgmii_clock
From: Nicolas Ferre <nicolas.ferre@microchip.com>
Date: 2024-12-06 09:47:11
Also in:
imx, linux-arm-kernel, linux-arm-msm, linux-devicetree, lkml
On 05/12/2024 at 17:43, Jan Petrous via B4 Relay wrote:
From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com> Utilize a new helper function rgmii_clock(). Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Russell King (Oracle) <redacted> Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
If needed: Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks, best regards, Nicolas
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/cadence/macb_main.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index daa416fb1724..640f500f989d 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c@@ -530,19 +530,9 @@ static void macb_set_tx_clk(struct macb *bp, int speed) if (bp->phy_interface == PHY_INTERFACE_MODE_MII) return; - switch (speed) { - case SPEED_10: - rate = 2500000; - break; - case SPEED_100: - rate = 25000000; - break; - case SPEED_1000: - rate = 125000000; - break; - default: + rate = rgmii_clock(speed); + if (rate < 0) return; - } rate_rounded = clk_round_rate(bp->tx_clk, rate); if (rate_rounded < 0) --2.47.0