Re: [PATCH net] net/mlx5: DR, prevent potential error pointer dereference
From: Mateusz Polchlopek <hidden>
Date: 2024-12-05 08:53:49
Also in:
kernel-janitors, linux-rdma, lkml
From: Mateusz Polchlopek <hidden>
Date: 2024-12-05 08:53:49
Also in:
kernel-janitors, linux-rdma, lkml
On 12/5/2024 9:32 AM, Leon Romanovsky wrote:
On Tue, Dec 03, 2024 at 11:02:15AM +0100, Mateusz Polchlopek wrote:quoted
On 12/3/2024 10:44 AM, Yevgeny Kliteynik wrote:quoted
On 03-Dec-24 11:39, Dan Carpenter wrote:quoted
On Tue, Dec 03, 2024 at 10:32:13AM +0100, Mateusz Polchlopek wrote:quoted
On 11/30/2024 11:01 AM, Dan Carpenter wrote:quoted
The dr_domain_add_vport_cap() function genereally returns NULL on errorTypo. Should be "generally"Sure.quoted
quoted
but sometimes we want it to return ERR_PTR(-EBUSY) so the caller can retry. The problem here is that "ret" can be either -EBUSY or -ENOMEMPlease remove unnecessary space.What are you talking about?Oh, I see it :) Double space between "retry." and "The" -- YKYup, exactly. Sorry, I could point it.Double space after period is perfectly valid typographic style. It is with us for last 250 years. Thanks
Cool, thanks for explanation and please forget about this unnecessary nitpick :) Thanks
quoted
quoted
quoted
regards, dan carpenter