-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of Konrad Knitter
Sent: 11 December 2024 16:34
To: <redacted>
Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; <redacted>; kuba@kernel.org; pabeni@redhat.com; <redacted>; davem@davemloft.net; andrew+netdev@lunn.ch; brett.creeley@amd.com; <redacted>; Knitter, Konrad <redacted>
Subject: [Intel-wired-lan] [PATCH iwl-next v4] ice: add fw and port health reporters
Firmware generates events for global events or port specific events.
Driver shall subscribe for health status events from firmware on supported FW versions >= 1.7.6.
Driver shall expose those under specific health reporter, two new reporters are introduced:
- FW health reporter shall represent global events (problems with the image, recovery mode);
- Port health reporter shall represent port-specific events (module failure).
Firmware only reports problems when those are detected, it does not store active fault list.
Driver will hold only last global and last port-specific event.
Driver will report all events via devlink health report, so in case of multiple events of the same source they can be reviewed using devlink autodump feature.
$ devlink health
pci/0000:b1:00.3:
reporter fw
state healthy error 0 recover 0 auto_dump true
reporter port
state error error 1 recover 0 last_dump_date 2024-03-17
last_dump_time 09:29:29 auto_dump true
$ devlink health diagnose pci/0000:b1:00.3 reporter port
Syndrome: 262
Description: Module is not present.
Possible Solution: Check that the module is inserted correctly.
Port Number: 0
Tested on Intel Corporation Ethernet Controller E810-C for SFP
Reviewed-by: Marcin Szycik <redacted>
Co-developed-by: Sharon Haroni <redacted>
Signed-off-by: Sharon Haroni <redacted>
Co-developed-by: Nicholas Nunley <redacted>
Signed-off-by: Nicholas Nunley <redacted>
Co-developed-by: Brett Creeley <redacted>
Signed-off-by: Brett Creeley <redacted>
Signed-off-by: Konrad Knitter <redacted>
---
v4: Extended documentation to ice_is_fw_health_report_supported.
Comparing host byte order event_source.
v3: Changed patch title to add health reporters. Style fixes.
https://lore.kernel.org/intel-wired-lan/20241209093204.173817-1-konrad.knitter@intel.com/T/#u (local)
v2: Removal of __VA_OPS__ usage. Style fixes.
https://lore.kernel.org/intel-wired-lan/20241209111359.GA2581@kernel.org/T/#t (local)
v1: Initial version
https://lore.kernel.org/intel-wired-lan/20241118104810.477794-1-konrad.knitter@intel.com/#t (local)
Depends-on: https://lore.kernel.org/netdev/20240930133724.610512-1-przemyslaw.kitszel@intel.com/T/ (local)
---
.../net/ethernet/intel/ice/devlink/health.c | 295 +++++++++++++++++-
.../net/ethernet/intel/ice/devlink/health.h | 14 +-
.../net/ethernet/intel/ice/ice_adminq_cmd.h | 87 ++++++
drivers/net/ethernet/intel/ice/ice_common.c | 38 +++
drivers/net/ethernet/intel/ice/ice_common.h | 2 +
drivers/net/ethernet/intel/ice/ice_main.c | 3 +
drivers/net/ethernet/intel/ice/ice_type.h | 5 +
7 files changed, 436 insertions(+), 8 deletions(-)
Tested-by: Rinitha S <redacted> (A Contingent worker at Intel)