Re: [PATCH v1 13/16] net-next/yunsilicon: Add eth rx

Thank you for your suggestion. I will address this issue in the next 
version and avoid using inline functions in the .c files.


On 2024/12/19 3:47, Andrew Lunn wrote:

quoted

+++ b/drivers/net/ethernet/yunsilicon/xsc/net/xsc_eth_rx.c

@@ -33,10 +33,572 @@
   * SOFTWARE.
   */
  
+#include <linux/net_tstamp.h>
+#include "xsc_eth.h"
  #include "xsc_eth_txrx.h"
+#include "xsc_eth_common.h"
+#include <linux/device.h>
+#include "common/xsc_pp.h"
+#include "xsc_pph.h"
+
+#define PAGE_REF_ELEV  (U16_MAX)
+/* Upper bound on number of packets that share a single page */
+#define PAGE_REF_THRSD (PAGE_SIZE / 64)
+
+static inline void xsc_rq_notify_hw(struct xsc_rq *rq)
+{

Please don't use inline functions in .c files. Let the compiler
decide.

	Andrew