Re: [PATCH net-next v6 3/4] selftests: net: test SO_PRIORITY ancillary data with cmsg_sender
From: Ido Schimmel <hidden>
Date: 2024-12-11 10:02:10
On Tue, Dec 10, 2024 at 08:13:08PM +0100, Anna Emese Nyiri wrote:
Extend cmsg_sender.c with a new option '-Q' to send SO_PRIORITY ancillary data. cmsg_so_priority.sh script added to validate SO_PRIORITY behavior by creating VLAN device with egress QoS mapping and testing packet priorities using flower filters. Verify that packets with different priorities are correctly matched and counted by filters for multiple protocols and IP versions. Suggested-by: Ido Schimmel <redacted> Signed-off-by: Anna Emese Nyiri <redacted>
Reviewed-by: Ido Schimmel <idosch@nvidia.com> Tested-by: Ido Schimmel <idosch@nvidia.com> Few nits that you can address in a follow up
quoted hunk ↗ jump to hunk
@@ -252,6 +259,8 @@ cs_write_cmsg(int fd, struct msghdr *msg, char *cbuf, size_t cbuf_sz) ca_write_cmsg_u32(cbuf, cbuf_sz, &cmsg_len, SOL_SOCKET, SO_MARK, &opt.mark); + ca_write_cmsg_u32(cbuf, cbuf_sz, &cmsg_len, + SOL_SOCKET, SO_PRIORITY, &opt.priority);
Need to align to the open parenthesis
quoted hunk ↗ jump to hunk
ca_write_cmsg_u32(cbuf, cbuf_sz, &cmsg_len, SOL_IPV6, IPV6_DONTFRAG, &opt.v6.dontfrag); ca_write_cmsg_u32(cbuf, cbuf_sz, &cmsg_len,diff --git a/tools/testing/selftests/net/cmsg_so_priority.sh b/tools/testing/selftests/net/cmsg_so_priority.sh new file mode 100755 index 000000000000..1fdfe6939a97 --- /dev/null +++ b/tools/testing/selftests/net/cmsg_so_priority.sh
[...]
+fi +
Unnecessary blank line: Applying: selftests: net: test SO_PRIORITY ancillary data with cmsg_sender .git/rebase-apply/patch:228: new blank line at EOF. + warning: 1 line adds whitespace errors.