Thread (28 messages) 28 messages, 4 authors, 2024-11-11

Re: [PATCH net-next v2 02/13] virtio_ring: split: record extras for indirect buffers

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2024-11-06 07:42:38
Also in: bpf, virtualization

On Wed, Nov 06, 2024 at 09:44:39AM +0800, Jason Wang wrote:
quoted
quoted
quoted
        while (vq->split.vring.desc[i].flags & nextflag) {
-               vring_unmap_one_split(vq, i);
+               vring_unmap_one_split(vq, &extra[i]);
Not sure if I've asked this before. But this part seems to deserve an
independent fix for -stable.
What fix?
I meant for hardening we need to check the flags stored in the extra
instead of the descriptor itself as it could be mangled by the device.

Thanks
Good point. Jason, want to cook up a patch?

-- 
MST
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help