Re: [RESEND PATCH] net: microchip: vcap: Add typegroup table terminators in kunit tests

On 11/20/24 15:58, Guenter Roeck wrote:

On Wed, Nov 20, 2024 at 10:52:02AM +0000, Daniel Machon wrote:

quoted

Hi Guenter,

quoted

Comments in the code state that "A typegroup table ends with an all-zero
terminator". Add the missing terminators.

Some of the typegroups did have a terminator of ".offset = 0, .width = 0,
.value = 0,". Replace those terminators with "{ }" (no trailing ',') for
consistency and to excplicitly state "this is a terminator".

Fixes: 67d637516fa9 ("net: microchip: sparx5: Adding KUNIT test for the VCAP API")
Cc: Steen Hegelund <steen.hegelund@microchip.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
resend: forgot to copy netdev@.

You are missing the target tree in the subject - in this case it should be
'net'

Sorry, I seem to be missing something. The subject starts with
"net: microchip: vcap: Add ...". How should it look like instead ?

The correct subject should have been:

[PATCH net RESEND] net: microchip: vcap: Add typegroup table terminators
in kunit tests

the target tree is identified by the subj prefix - whatever is enclosed
by []:

https://elixir.bootlin.com/linux/v6.11.8/source/Documentation/process/maintainer-netdev.rst#L12

Please don't resent this patch just to address the above, but please
keep in mind for future submissions.

Thanks,

Paolo