Re: [PATCH v7 1/2] mctp pcc: Check before sending MCTP PCC response ACK

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge linus/master v6.12-rc7 next-20241115]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/admiyo-os-amperecomputing-com/mctp-pcc-Check-before-sending-MCTP-PCC-response-ACK/20241114-105151
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20241114024928.60004-2-admiyo%40os.amperecomputing.com
patch subject: [PATCH v7 1/2] mctp pcc: Check before sending MCTP PCC response ACK
config: x86_64-randconfig-161-20241117 (https://download.01.org/0day-ci/archive/20241117/202411170906.mCmSa3oY-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411170906.mCmSa3oY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot [off-list ref]
| Closes: https://lore.kernel.org/oe-kbuild-all/202411170906.mCmSa3oY-lkp@intel.com/ (local)

All error/warnings (new ones prefixed by >>):

   In file included from drivers/cpufreq/acpi-cpufreq.c:31:
   In file included from include/acpi/cppc_acpi.h:17:

quoted

include/acpi/pcc.h:51:10: error: expected ';' after return statement

      51 |         return 0
         |                 ^
         |                 ;

quoted

include/acpi/pcc.h:49:5: warning: no previous prototype for function 'pcc_mbox_ioremap' [-Wmissing-prototypes]

      49 | int pcc_mbox_ioremap(struct mbox_chan *chan)
         |     ^
   include/acpi/pcc.h:49:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      49 | int pcc_mbox_ioremap(struct mbox_chan *chan)
         | ^
         | static 
   1 warning and 1 error generated.
--
   In file included from drivers/cpufreq/intel_pstate.c:30:
   In file included from include/trace/events/power.h:12:
   In file included from include/linux/trace_events.h:6:
   In file included from include/linux/ring_buffer.h:5:
   In file included from include/linux/mm.h:2213:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   In file included from drivers/cpufreq/intel_pstate.c:48:
   In file included from include/acpi/cppc_acpi.h:17:

quoted

include/acpi/pcc.h:51:10: error: expected ';' after return statement

      51 |         return 0
         |                 ^
         |                 ;

quoted

include/acpi/pcc.h:49:5: warning: no previous prototype for function 'pcc_mbox_ioremap' [-Wmissing-prototypes]

      49 | int pcc_mbox_ioremap(struct mbox_chan *chan)
         |     ^
   include/acpi/pcc.h:49:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      49 | int pcc_mbox_ioremap(struct mbox_chan *chan)
         | ^
         | static 
   4 warnings and 1 error generated.


vim +51 include/acpi/pcc.h

    36	
    37	#ifdef CONFIG_PCC
    38	extern struct pcc_mbox_chan *
    39	pcc_mbox_request_channel(struct mbox_client *cl, int subspace_id);
    40	extern void pcc_mbox_free_channel(struct pcc_mbox_chan *chan);
    41	extern int pcc_mbox_ioremap(struct mbox_chan *chan);
    42	#else
    43	static inline struct pcc_mbox_chan *
    44	pcc_mbox_request_channel(struct mbox_client *cl, int subspace_id)
    45	{
    46		return ERR_PTR(-ENODEV);
    47	}
    48	static inline void pcc_mbox_free_channel(struct pcc_mbox_chan *chan) { }
  > 49	int pcc_mbox_ioremap(struct mbox_chan *chan)
    50	{
  > 51		return 0
    52	};
    53	#endif
    54	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki