Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script
From: Christophe JAILLET <hidden>
Date: 2024-11-16 06:06:10
Also in:
ath11k, ceph-devel, cocci, dri-devel, intel-xe, linux-block, linux-bluetooth, linux-mm, linux-s390, linux-scsi, linux-sound, linux-staging, linux-wireless, linuxppc-dev, live-patching, lkml, netfilter-devel, xen-devel
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit :
quoted hunk ↗ jump to hunk
Suggested-by: Anna-Maria Behnsen <anna-maria@linutronix.de> Signed-off-by: Easwar Hariharan <redacted> --- scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci new file mode 100644 index 0000000000000000000000000000000000000000..af762b1c0aac8f044f21150bfaafd9efc834ee87 --- /dev/null +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci@@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Find usages of: +/// - msecs_to_jiffies(value*1000) +/// - msecs_to_jiffies(value*MSEC_PER_SEC) +/// +// Confidence: High +// Copyright: (C) 2024 Easwar Hariharan Microsoft +// +// Keywords: secs, seconds, jiffies +// + +@@ constant C; @@ + +- msecs_to_jiffies(C * 1000) ++ secs_to_jiffies(C) + +@@ constant C; @@ + +- msecs_to_jiffies(C * MSEC_PER_SEC) ++ secs_to_jiffies(C)
Hi, @@ constant C =~ "000"; @@ * msecs_to_jiffies(C) also spots things like msecs_to_jiffies(1000) I'm not sure that coccinelle is enable to capture part of the regex to automate the removal of the 000 when converting from ms to s. Just my 2c, CJ