Re: [PATCH net v2] ipmr: Fix access to mfc_cache_list without lock held

On Thu, Nov 14, 2024 at 07:03:08AM -0800, Jakub Kicinski wrote:

On Thu, 14 Nov 2024 00:55:57 -0800 Breno Leitao wrote:

quoted

On Wed, Nov 13, 2024 at 07:10:23PM -0800, Jakub Kicinski wrote:

quoted

On Fri, 08 Nov 2024 06:08:36 -0800 Breno Leitao wrote:  

quoted

Accessing `mr_table->mfc_cache_list` is protected by an RCU lock. In the
following code flow, the RCU read lock is not held, causing the
following error when `RCU_PROVE` is not held. The same problem might
show up in the IPv6 code path.  

good start, I hope someone can fix the gazillion warnings the CI 
is hitting on the table accesses :)  

If you have an updated list, I'd be happy to take a look.

Last time, all the problems I found were being discussed upstream
already. I am wondering if they didn't land upstream, or, if you have
warnings that are not being currently fixed.

https://netdev-3.bots.linux.dev/vmksft-forwarding-dbg/results/859762/82-router-multicast-sh/stderr

This one seems to be discussed in the following thread already.

https://lore.kernel.org/all/20241017174109.85717-1-stefan.wiehler@nokia.com/ (local)