Re: [PATCH net v2]: stmmac: dwmac-intel-plat: fix call balance of tx_clk handling routines

Hi,

On Mon, 11. Nov 12:39, Dan Carpenter wrote:

smatch warnings:
drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c:163 intel_eth_plat_probe() error: we previously assumed 'dwmac->data' could be null (see line 101)

There is a patch [1] targeted at net-next tree which removes the check. I
think there should be v2 posted soon.

As it's not the first time Smatch is pointing at this issue [2], is there
something to improve? I mean, posting the patches in form of a series or
explaining in commit message that the check is redundant and is a subject
for removal? Adding new redundant checks for the fix-patch would not be
good..

What would be the most appropriate way?

[1]: https://lore.kernel.org/netdev/20240930183926.2112546-1-mordan@ispras.ru/ (local)
[2]: https://lore.kernel.org/netdev/20241003111811.GJ1310185@kernel.org/ (local)

--
Thanks,
Fedor