[PATCH] netlink: Fix off-by-one error in netlink_proto_init()

From: Markus Elfring <redacted>
Date: Sun, 3 Nov 2024 14:01:26 +0100

Hash tables should be properly destroyed after a rhashtable_init() call
failed in this function implementation.
The corresponding exception handling was incomplete because of
a questionable condition check.
Thus use the comparison operator “>=” instead for the affected while loop.

This issue was transformed by using the Coccinelle software.

Fixes: e341694e3eb5 ("netlink: Convert netlink_lookup() to use RCU protected hash table")
Cc: stable@vger.kernel.org
Signed-off-by: Markus Elfring <redacted>
---
 net/netlink/af_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 0a9287fadb47..9601b85dda95 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c

@@ -2936,7 +2936,7 @@ static int __init netlink_proto_init(void)
 	for (i = 0; i < MAX_LINKS; i++) {
 		if (rhashtable_init(&nl_table[i].hash,
 				    &netlink_rhashtable_params) < 0) {
-			while (--i > 0)
+			while (--i >= 0)
 				rhashtable_destroy(&nl_table[i].hash);
 			kfree(nl_table);
 			goto panic;
--

2.47.0