Re: [PATCH net-next V3 3/8] devlink: Extend devlink rate API with traffic classes bandwidth management

Tue, Nov 19, 2024 at 03:51:18PM CET, kuba@kernel.org wrote:

On Tue, 19 Nov 2024 15:46:28 +0100 Jiri Pirko wrote:

quoted

quoted

quoted

Not sure. Perhaps Jakub/Donald would know. Ccing.  

I haven't read full context, but all "nested" arrays are discouraged.
Use:
multi-attr: true
and repeat the entries without wrapping them into another attr.  

But we need to use the array index. It looks a bit odd to me to depent
on the index in multi-attr in general. It is not guaranteed other
atrributes don't get in the middle. Ordering should be maintained, that
is ok.

How about to have a nest that contain just one multi-attr attribute?

You can make the entry a nest and put the index inside, if it is 
significant.

Okay, sounds fine to me.