Re: [PATCH net-next v2 5/8] net: ip_gre: Add netns_atomic module parameter

From
Xiao Liang <hidden>
Date
2024-11-07 16:54:31
Also in
linux-kselftest
Reply to
Jakub Kicinski, 2024-11-07
On Thu, Nov 7, 2024 at 11:59 PM Jakub Kicinski [off-list ref] wrote:
On Thu, 7 Nov 2024 22:11:24 +0800 Xiao Liang wrote:
quoted
quoted
Instead, add new rtnetlink attributes ?
It is to control driver behavior at rtnl_ops registration time. I
think rtnetlink
attributes are too late for that, maybe? Can't think of a way other than
module parameters or register separate ops. Any suggestions?
Step back from the implementation you have a little, forget that there
is a boolean in rtnl_link_ops. User makes a request to spawn an
interface, surely a flag inside that request can dictate how the netns
attrs are interpreted.
IMO, this is about driver capability, not about user requests.
As you've pointed out earlier, probably no one would actually want
the old behavior whenever the driver supports the new one.
I added the module parameter just for compatibility, because ip_tunnels
was not implemented to support src_net properly. Yes it's possible to
add an extra flag in user request, but I don't think it's a good approach.

BTW, I didn't find what's going on with module parameters, is there
any documentation?

Thanks.
Thread (26 messages) 26 messages, 4 authors, last reply 2024-11-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help