Re: [PATCH bpf v2 0/4] bpf, vsock: Fixes related to sockmap/sockhash redirection

On Sun, Oct 13, 2024 at 06:26:38PM +0200, Michal Luczaj wrote:

Series consists of few fixes for issues uncovered while working on a BPF
sockmap/sockhash redirection selftest.

The last patch is more of a RFC clean up attempt. Patch claims that there's
no functional change, but effectively it removes (never touched?) reference
to sock_map_unhash().

Signed-off-by: Michal Luczaj <redacted>
---
Changes in v2:
- Patch 2/4: Send a credit update [Stefano]
- Collect Reviewed-by
- Link to v1: https://lore.kernel.org/r/20241009-vsock-fixes-for-redir-v1-0-e455416f6d78@rbox.co (local)

For the virtio-vsock point of view, the series LGTM and I reviewed patch 
2 and 3. I don't know BPF enough for the rest but I can't see anything 
wrong.

Thanks,
Stefano

---
Michal Luczaj (4):
     bpf, sockmap: SK_DROP on attempted redirects of unsupported af_vsock
     vsock: Update rx_bytes on read_skb()
     vsock: Update msg_count on read_skb()
     bpf, vsock: Drop static vsock_bpf_prot initialization

include/net/sock.h                      |  5 +++++
net/core/sock_map.c                     |  8 ++++++++
net/vmw_vsock/virtio_transport_common.c | 14 ++++++++++++--
net/vmw_vsock/vsock_bpf.c               |  8 --------
4 files changed, 25 insertions(+), 10 deletions(-)
---
base-commit: afeb2b51a761c9c52be5639eb40460462083f222
change-id: 20241009-vsock-fixes-for-redir-86707e1e8c04

Best regards,
-- 
Michal Luczaj [off-list ref]