Re: [PATCH v4 2/2] vsock/test: fix parameter types in SO_VM_SOCKETS_* calls
From: Konstantin Shkolnyy <hidden>
Date: 2024-10-31 16:04:15
Also in:
lkml, virtualization
From: Konstantin Shkolnyy <hidden>
Date: 2024-10-31 16:04:15
Also in:
lkml, virtualization
On 10/31/2024 09:16, Stefano Garzarella wrote:
On Tue, Oct 29, 2024 at 09:49:54AM -0500, Konstantin Shkolnyy wrote:quoted
Change parameters of SO_VM_SOCKETS_* to uint64_t so that they are alwaysIn include/uapi/linux/vm_sockets.h we talk about "unsigned long long", but in the kernel code we use u64. IIUC "unsigned long long" should be u64 on every architecture, at least till we will have some 128-bit cpu, right?
I'm not sure what "unsigned long long" would be on a 128-bit machine.
What about using `unsigned long long` as documented in the vm_sockets.h?
I use uint64_t because the kernel uses u64. I think, this way the code isn't vulnerable to potential variability of "unsigned long long". If we change to "unsigned long long" should we also change the kernel to "unsigned long long"?