Thread (18 messages) 18 messages, 5 authors, 2024-10-31

Re: [PATCH v4 4/7] rust: time: Add wrapper for fsleep function

From: Thomas Gleixner <hidden>
Date: 2024-10-29 07:55:52
Also in: lkml, rust-for-linux

On Tue, Oct 29 2024 at 08:30, FUJITA Tomonori wrote:
On Sun, 27 Oct 2024 21:38:41 -0700
Boqun Feng [off-list ref] wrote:
quoted
That also works for me, but an immediate question is: do we put
#[must_use] on `fsleep()` to enforce the use of the return value? If
yes, then the normal users would need to explicitly ignore the return
value:

	let _ = fsleep(1sec);

The "let _ =" would be a bit annoying for every user that just uses a
constant duration.
Yeah, but I don't think that we have enough of an excuse here to break
the rule "Do not crash the kernel".

Another possible option is to convert an invalid argument to a safe
value (e.g., the maximum), possibly with WARN_ON_ONCE().
That makes sense.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help